Francesco Pannarale
Francesco Pannarale
We have a first take on the PyGRB results webpage in the standard PyCBC format [here](https://ligo.gravity.cf.ac.uk/~francesco.pannarale/LVC/new_pygrb_webpage_3/). Right now it has most of what was on the old webpages, but there...
Comparing the [latest results webpage](https://ldas-jobs.ligo.caltech.edu/~francesco.pannarale/LVC/pygrb_dev_webpage2/) to the [most complete one](https://ldas-jobs.ligo.caltech.edu/~francesco.pannarale/LVC/py3_pygrb_webpage_3/) generated when using old xml results files, the items missing are - [ ] tables of missed and quiet injections...
Regarding https://github.com/gwastro/pycbc/pull/4485 , let's - [ ] rely on already existing functions for angular/cartesian conversions, if possible - [ ] check conventions (coordinates especially) - [ ] fix a small...
The call to `time_delay_from_earth_center` in `pycbc_multi_inspiral` is inserted in a triple loop on ifos, sky positions and time slides, but the time delay depends only on the IFO and the...
https://github.com/gwastro/pycbc/pull/4288 was merged but a few discussion points from this PR should be tracked. Namely - [ ] `new_snr_chisq` in `pycbc_pygrb_plot_chisq_veto` returns the chi-square value needed to weight SNR into...
- Passing options from `pycbc_multi_inspiral` command line to the methods that calculate null SNR, cut in null SNR, and calculate reweighted SNR. - Renaming `n_ifo` as `ifo_idx` to avoid confusion...
Vetoes
- [ ] In `def load_triggers(input_file, vetoes):` (pycbc/pycbc/results/pygrb_postprocessing_utils.py) the vetoes need to be implemented. There should be old (xml) code in PR #3972. A rough scheme is ``` # =============================================================================...
Clean up
Once a "complete" pygrb workflow has gone through, we need to run pylint or an equivalent on all PyGRB executables, pygrb_plotting_utils.py, pygrb_postprocessing_utils.py, and grb_utils.py and respond to what it raises....
- [ ] The vetoed injections category is now ambiguous. It used to contain vetoed injections by looking for cases with reweighted SNR = 0, but now the cut by...
This is mostly making sure indentations and line lengths are correct in `pycbc_pygrb_plot_coh_ifosnr` and `pycbc_pygrb_minifollowups`. In the latter case, I also removed unnecessary variables and options. The scripts were successfully...