Palani Kumanan

Results 13 comments of Palani Kumanan

I'm also seeing the issue. Coverage includes test files and source files. Path to source file: `src` Path to test files: `browser-test` Here is my config file: ```JS module.exports =...

What do you think of this: Along the lines of `all()`, introduce `some()` with additional parameter(s) for methods. ``` router.route('/') .some(['GET', 'POST'], function (req, res, next) { ... }); ```...

Your code looks ok and I am able to run it locally with correct cors response. Could you add `$corsOptions` to `routeMiddleware()` and try. ``` \CorsSlim\CorsSlim::routeMiddleware($corsOptions) ```

The issue is with pre-flight call. With `routeMiddleware` you have to explicitly support `OPTIONS` calls for [Preflighted requests](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Preflighted_requests), like this: ``` php $app->options('/item', \CorsSlim\CorsSlim::routeMiddleware(), function () use ($app) {} );...

@bujardeari Are you using Slim 3.x? If so, please use [dev-slim3 branch](https://packagist.org/packages/palanik/corsslim#dev-slim3).

@kiwina You want to send me a PR? I'll merge it.

@bobeagan Thanks for the PR. I will review & get back to you.

@bobeagan I see that you switched to `POST` method for some endpoints to match preferred method from slack api docs. This will break if the endpoint is called with no...

Slack docs say less-than sign & greater-than sign need to be escaped. > Replace the less-than sign, ` Replace the greater-than sign, `>` with `>` More info: https://api.slack.com/reference/surfaces/formatting#escaping Can you...

Thanks @humphd for bringing this to my attention. No one else has reported similar issue. Unfortunately, I don't have a Windows machine with me at this time to check this....