Pierre-Antoine Lacaze
Pierre-Antoine Lacaze
Hi Claus. Thank you for submitting this PR, a lot of stuff in there! I do not have the time to review everything, I will try to sum up my...
Hi, This seems easy enough to implement and would be a handy tool for unit testing. Should the spy be templated over the signal arguments? That would be easier to...
I assume the spy will be used in a multi-threaded context, wait() being a blocking call? QSignalSpy creates an event loop whenever wait() gets invoked. This loop is responsible for...
There is no obvious solution, I do not think implementing a generic event-loop agnostic spy is a good idea. Generally speaking, the wait() method should start or defer the wait...
Thank you for the feedback. I actually use an improved and thread-safe variant of the `sigslot::spy` to wait for signals in production code. This lets me transform async code into...
I do not, but basically signals are used to asynchronously emit results from a network request, and I use a SignalWaiter to transform this asynchronous emission into a synchronous blocking...
I am on the fence over this one. On one hand event based programming is hardly compatible with exceptions, so adding this try catch block makes sense, On the other...
Hi gamagan, I cannot commit to keeping this base class. I considered removing it altogether a few months ago while refactoring the disconnection mechanism. You might solve this differently by...
Thanks for the detailed report. I agree that the current implementation is not optimal with respect to arguments forwarding. The first part of your suggested fix is simple to apply,...
So, I had an idea for a quick-fix by performing a conditional move depending on the type of each argument to `call_slot()`. I pushed a proof of concept on the...