Sergei Zherevchuk

Results 9 comments of Sergei Zherevchuk

@superbobry Should I commit changes for `cdatrie.pxd` to fix travis? Anything else?

@omab How about to merge this PR? :) `git blame` shows that `replaces` attribute was added 5 years ago, that's enough time to migrate to the new app. It looks...

@atodorov That was definitely a long-lived bug https://code.djangoproject.com/ticket/25255 I'm not really concerned about unapplying migrations, just don't like the idea that "squashed" migrations leaking into `default` and `social_auth` app namespaces...

manspouse, I test your solution on chrome (mac os) and find a bug. How can I fix this? 1. Open standard dropdown menu and try to scroll up/down list. Work's...

> Hmm, what happens right now in that case? Does the code just crash? 500 error if none of the auth backends allowed to log in as a target user,...

Please look at https://github.com/skorokithakis/django-loginas/pull/84 With this PR I could check target user activity in `can_login_as` function and raise proper error message like "You can't log in as inactive user". How...

@skorokithakis `ImproperlyConfigured` could be raised later in `user_login` view if use default `can_login_as` function and try to log in as inactive user. https://github.com/skorokithakis/django-loginas/blob/0525348f3b9229215ba455085389b36af585b8ee/loginas/views.py#L72-L76 There is no try-except block right now....

Well, technically it would stop propagating exception which could be processed by middleware, but I couldn't imagine anyone who actually relies on this behavior. :) Showing an error should be...