p3t3rix

Results 12 comments of p3t3rix

So i tried my hand at the QueryPool by liberally copying parts of the ctor, something along those lines: ``` /// Creates a new `QueryPool` from an ash-handle /// #...

After https://github.com/vulkano-rs/vulkano/pull/1938 the following things wrap ash internally and still need to be discussed if they need a from_handle function and how it should look like: - ShaderModule - GraphicsPipeline...

I looked into this and as far as i can tell it would require a quite separate functionality, because at the moment all things are done via syntax analysis on...

I just wanted to add that while the mentioned project does mark these properties it is not possible to abstract this magic comment so that your team members will remember...

I found another project that does something similar but is not as easily dismissable as a comment: https://github.com/oliverhanappi/ManualMappingGuard

I have nothing against the solution, i just wanted to list alternatives for people like me that think that an annotation is a cleaner way to express that a method...

Is there a different PR that implements this or was the rewrite of the testcases the reason this was closed ?

@sunkin351 This was not meant as a critique and i hope you don't take it personally. The comments i did were purely on this document with the help of some...

VulkanMemoryAllocatorCreateInfo struct would be nice to have in the document so we can discuss which stuff is actually needed to create one.

![diag](https://user-images.githubusercontent.com/5238284/135768127-9c9940cd-9be6-47fe-8cf0-0887b649f0ec.png) well i tried to create some kind of basic overview diagram to highlight the public relations of the classes (plantuml source in the spoiler at the end). So basically...