Ozan Kaşıkçı
Ozan Kaşıkçı
Hi @Olney1, if you wish, feel free to contribute!
Not sure if this is the desired outcome for every case. Maybe can be an option though.
@martingronlund thank you. I agree that a chord should never have an empty list of intervals. However i'm not sure how would making the Chord a trait prevent that? The...
Hi Martin, can you please explain what you mean with some concrete code examples? because i'm not sure if i'm following what you mean here.
Thanks for elaborating, Martin! :) Now i know your reasoning and what you meant. This sounds like a more flexible way of representing chords. But of course would require some...
Hi! Thanks for your interest @peterkos! > However I can't seem to find which modes are missing. There are missing modes for Harmonic Minor and Melodic minor scales. For example,...
> Also I'd like to know why they're mentioned as `ScaleType` enum. The whole API is kinda confusing, so maybe we should refactor it a bit. My answer above should...
> Guess it's more of a "jazz theory" thing! Indeed, it's being used mostly by jazz musicians. > wouldn't the Mode enum still not include `HarmonicMinor` and `MelodicMinor`? This is...
`HarmonicMode` `AscendingMelodicMode` `DescendionMelodicMode` I like this, looks cleaner. Then we can add the missing modes for `Harmonic/Melodic Minor scales`.
Would be appreciated 👍