Owen Niblock

Results 33 comments of Owen Niblock

@harshjain2 - I'm speccing out a system for uploading and running tests and we need DataCollection for reporting and taking screenshots etc. I'd assessed the standard DataCollector and on a...

I suspect that the solution provided will cause problems for some screen readers. Looking at [the ARIA guidance for tabs](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Tab_Role) I can see that browsers automatically apply a role of...

> I wonder if TabNav should natively support an accessible activeTabButton to make this easier for consumers. Thanks a great idea @iansan5653 ! It totally makes sense to solve this...

[Slack discussion around the SelectPanel functionality here](https://github.slack.com/archives/C0FSWLQ0Y/p1661954660218019)

@jdrush89 Unfortunately this behavior would be incompatible with the accessible semantics of an element with `role="menu"`. For more information about the valid use of menus there's a good section [in...

I've also seen this issue, please let me know if additional reproduction steps would be helpful.

I do wonder if this is a bug or intended behaviour. Since the content of the element isn't changing (the whole element changes) perhaps not announcing the content is intentional...

Related / similar PR: https://github.com/primer/react/pull/4504

I think I would lean towards the simplest option (which in my mind is the first). However I'm not sure I fully comprehend this disadvantage: > node doesn't yet have...

Closing, hopefully https://github.com/primer/react/pull/4513 gives us everything we need 🤞