Sipi Ovaska
Sipi Ovaska
Are there any blockers to adding support for URLs as template directory, e.g. instead of a local directory, it could point to `https://somecompany.com/templates/`? It would be useful for sharing custom...
Replace lock with semaphore so event inside can be awaited.
https://github.com/IdentityModel/IdentityModel.AspNetCore.OAuth2Introspection/blob/main/src/OAuth2IntrospectionHandler.cs#L211 The `OnUpdateClientAssertion` event is invoked without an `await`, probably because it is inside a `lock`. This can potentially cause hard to diagnose bugs if the event is assigned to...
I tried to make the changes as non-intrusive to the codebase as possible. Added unit tests for verify the functionality against current version. Each change is in its' own commit,...
There are a couple of places where per-request performance can be improved, mainly in number of allocations. I'd be happy to contribute with some improvements and unit tests. Let me...
Caused by #1522 Example from string serialized enums, here is the source enum: ```cs public enum Scope { Value1 = 1, Value2 = 2, Value3 = 3, } ``` Relevant...
This is almost a non-issue, but `AsEnumerable` reports "Object allocation: LINQ method call" when used on reference types. When used on a struct, an allocation is reported on the variable...
Connected notes of the same pitch don't play if the second note's articulation uses a different midi channel. The problem is illustrated in the pictures below, first note is on...
Great and super useful script! I have a small UI customization request. Most of the time on my workflow, the midi channel selector, articulation filter and the bank name are...
Currently for all non-empty inputs an array is rented from the pool. My naive assumption is, however, that the pool is commonly used for shorter strings. I suggest `stackalloc` be...