Neil Shen

Results 117 comments of Neil Shen

`StorageSize()` seems to be fast if we calculate the size of the full range. Also, I suggest we should maintain an approximate size which can be `last calculated storage size...

> `epoch not match: EpochNotMatch conf_ver: 69 version: 890 != conf_ver: 71 version: 890` This error means raft member has changed. (conf_ver: raft member version, version: region range version). More...

> epoch not match: EpochNotMatch conf_ver: 69 version: 890 != conf_ver: 71 version: 890 This is misleading, it's not the root cause. > err=message:"EpochNotMatch [region 8348] 8351 epoch changed conf_ver:...

Here are some metrics and TiKV flamegraph. ![image](https://user-images.githubusercontent.com/2150711/125089734-311af800-e101-11eb-8f04-38b365c41e03.png) TiKV flamegraph: https://gist.github.com/overvenus/389739d09a155938d3d5016b2f55a3f7

For the second task, we can port TiKV cgroup detection https://github.com/tikv/tikv/blob/7b677d60ab3b60b3ef4750da09718ba8114060ed/components/tikv_util/src/sys/cgroup.rs

That's great! Looks like all we need to do is to add a check to prevent BR 4.0 to backup/restore TiDB 5.0.

Versions of the nightly release of TiDB and TiKV are wrong, TiDB shows 4.0.0-beta.2, TiKV shows 4.1.0-alpha 😢

> why not just don't generate those empty SSTs in the first place Updated, thanks for your suggestion!