Olivier Valentin

Results 17 comments of Olivier Valentin

> It might not be only a ChromeOS-related issue I confirm that I had this elsewhere (flatpak in RHEL) **workaround for the flatpak distribution:** As a clue for people hitting...

To build on the above idea that "status" is feature-specific, I think that we should specify the potential values for it (even if they are not implemented in the MVP)....

> I might still have a string be a member of each version of status, which could allow for flexible configuration. protobuf types can evolve by adding supplementary fields in...

Why are P and Z not using `identify-image-platforms.outputs.supported_archs` instead of the `multiarch` label ?

A strange error occurred https://github.com/stackrox/collector/actions/runs/7613242274/job/20732912611?pr=1483#step:15:41 But once this is solved, I suggest to remove the `run-multiarch-build` to see whether the tests are skipped.

I rebased on top of @Molter73 's ContainerInfo introspection endpoint. We now share a common base class. The env var had already been merged, so removed it from this PR....

> On a strategic level, I think that it would be cleaner to add parameters to the build than to add tests about the architecture as part of the build...

> Is this ready for review? Could you share how you made sure that it works as intended? This is a really important part of the PR description, so that...

> 1. The env vars for Sensor and Central are very similar ROX_ENABLE_EXTERNAL_IPS ROX_EXTERNAL_IPS. > If they are meant to be enabled or disabled together, I would use the same...

> I don't have anything golden, but can't we use simply `External IPs`? Actually, I think that at some point, we could have 'learned' IPs which would be internal. >...