Michal Bajer
Michal Bajer
@outsidethecode @VRamakrishna I've added one more comment in previous review items, please have a look :) Also please remember to re-request the review so I get a signal to review...
@garrettcam Thanks, it does solve the issue! However I'd prefer using the docker-compose in the repo without a change. I think the root cause might be caused by node 17+...
@ruzell22 `catch` and `finally` are Promise alternaives of try-catch block so you can use it, but in your case it doesn't clean up allocated resources. Please have a look at...
@ruzell22 Right now you're stopping the ledger right after `createTestInfrastructure` is done (i.e. before the benchmark is run). This works fine because your test doesn't use the ledger (it calls...
> Hi @petermetz, may I ask what are the origins of the "package-local.json" files if you happen to know the context? I have been trying to find out if it...
@petermetz Done, I've added the following to the commit: ``` - This is not permanent - we'd love to bring the package back once the necessary refactors are done! -...
> done once there are documented steps for easily reproducing a working development environment for new contributors regardless of that development environment Agree on this, different people have different needs...
@123wyl123 any updates regarding updating of tcs sample app?
@123wyl123 I'm happy to hear that! If you encounter any trouble please reach out to me :) Another thing which would be nice to do before our V2 release is...
@123wyl123 Hello, do you have any questions or problems regarding this? Please note that I've also opened a separate issue for open-api migration that I've mentioned in a previous comment...