Karsten Otto

Latest push includes suggestions so far. Re testability, I also added a second commit to make InMemoryMessageMapper honor the fetch type option - which immediately broke SimpleMessageSearchIndexTest.sortOnSentDateShouldWork(). Seems the UID...

OK, turns out honoring the fetch type breaks MemoryMessageMapperTest (and MemoryMessageWithAttachmentMapperTest), in different ways: 1. The messagesRetrieved... tests want bodyStartOctet to stay the same, regardless whether there actually is a...

> > Effectively, have the messages lie about what they actually have in their content byte array. > > No they are supposed to tell what the underlying data is...

This is interesting. In the latest version, InMemoryMessageMapper does lookup up an existing message by mailbox+UID and updates it if it exists. This breaks MemoryMessageIdMapperTest>MessageIdMapperTest.findMailboxesShouldReturnTwoMailboxesWhenMessageExistsInTwoMailboxes(). Turns out that when the...

Unfortunately I do not understand the implications of removing BODY fetch type enough to tackle it :(

Making InMemoryMessageMapper honor the fetch type seems to be a game of whack-a-mole. Issues crop up in parts of James I have never touched before, and I don't know how...

I put the InMemoryMessageMapper changes into https://github.com/ottoka/james-project/tree/JAMES-3799-MemoryMapper