otariidae

Results 9 comments of otariidae

Minimal reproduce code: ``` $ echo " " | jumanpp | knp ;; Invalid input (4 items) ! # S-ID:1 KNP:5.0-165d699 DATE:2020/09/18 SCORE:0.00000 ERROR:Cannot make mrph EOS ``` JUMAN++の出力: ```...

Hello. Time has passed since the last comment. Node.js 4 is now end of life. We can drop it. Moreover, new versions of Node.js have been released. We can run...

- I prefer `id` as it looks like a common practice in other libraries such as [comlink](https://github.com/GoogleChromeLabs/comlink/blob/dffe9050f63b1b39f30213adeb1dd4b9ed7d2594/src/comlink.ts#L613) and [typed-worker](https://github.com/egoist/typed-worker/blob/e601b9f0199dc22ecd603f6d4194d542ef7b9af0/src/index.ts#L79) - I also prefer to require `id` property to avoid the...

I am trying to make a PR and found another discussion point: - Error handling - Textlint worker should notify when `id` is missing or something goes wrong - Throwing...

Sorry, I found a simple oversight in my idea. When `id` is missing, the worker cannot respond with `id`. My idea works only if `id` exists and something goes wrong,...

My another idea is just to throw Error if `id` is missing to show that the worker will never work without `id`, and to respond with `TextlintWorkerCommandResponseError` if `id` exists...

My idea that just throws Error when missing `id` looks like this: ```typescript const id = crypto.randomUUID(); worker.addEventListener("message", function onResult(event) { const data: TextlintWorkerCommandResponse = event.data; if (data.id === id)...

I am considering that it may be better to first create a PR that provides error response messages for error handling, then make a PR that makes `id` required.