Ondřej Vejpustek
Ondřej Vejpustek
It seems to me that poetry2nix fails to install a package such that * the package is a development dependency and * the package is placed in a directory that...
Is there anything you want me to review?
> Sorry for not removing the request for your review earlier No problem. :)
@ph4r05 I apologize for being unresponsive, I must have missed the github notification. Anyway, as I told @matejcik earlier today, I don't usually have the capacity to review the monero...
> Also I merged master and made some improvements that the IDE is complaining about: various things like naming patterns, nullability issues and memory leaks: https://github.com/trezor/WalletWasabi/pull/3 I cherry picked the...
> If you don't want to keep your branch up to date with the master (which is probably why the diff is so bad in my PR to this, then...
> However, it is complex and after many hours of trying to understand how things are working The commits from https://github.com/zkSNACKs/WalletWasabi/pull/7932/commits/1830b9a8068acda6b04a483345f49db6fb85703b to https://github.com/zkSNACKs/WalletWasabi/pull/7932/commits/d7ca52acaa59983948b79270227d67a54123ed1b (inclusive) and the corresponding fixup commits are...
I'm not sure if it fixes https://github.com/zkSNACKs/WalletWasabi/issues/8763. Does it prevent [this loop](https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Tests/UnitTests/WabiSabi/Backend/PhaseStepping/StepTransactionSigningTests.cs#L246-L249) from looping forever if the round doesn't step into output registration phase?
> trusting the coordinator I think there is nothing bad on trusting the coordinator in this case. You trust other participants that they use the same amount decomposition algorithm, anyway....
> In that case the clients would not be able to build the final transaction and sign it. I mean to publish the real effective value of the input along...