Omar Kasem

Results 29 comments of Omar Kasem

@rafaehlers I tried to re create the issue but all flow fields are working in search except the users one, Is that the issue or am I missing something? Here's...

Hi @verysiberian Thanks for clearing the issue, I did some more testing and the 'multi user' field can't be searched using the regular search field because you would input the...

@mrcasual @zackkatz $field->update_configuration( array( 'number_format' => false ) ); $field->field->numberFormat = ''; $this->assertEquals( '7982489.239', $renderer->render( $field, $view, $form, $entry, $request ) ); So this part of the test is the...

@mrcasual Sorry for late reply here, this task was always very confusing for me, So before I work on it again i want to make sure of a couple of...

@mrcasual So It should be fixed now, the test `test_frontend_field_html_number` has an issue as it uses the field id 9 from complete.json and that field has a numberformat of 'currency'...

@doekenorg Thanks, I actually tried this function before but it only works on fields in views that has 'format_number' checked but the other one works on both, See screenshot for...

@doekenorg No worries at all :) And thanks for the new comments, It looks better now for sure

@mrcasual It's working but the tests needs to be changed as I mentioned before [here](https://github.com/GravityKit/GravityView/pull/1879#issuecomment-1757119144) So should I work on the tests change? If so I will need some help...

@mrcasual ![screenshot-gv local-2024 05 02-10_25_06](https://github.com/GravityKit/GravityView/assets/19789248/8ca21dd5-7509-4118-b324-44ff12613038) It should be working with the latest commit if i understood correctly

@mrcasual I added it on it's own function with all 4 possible tests it can go and i also added a fourth test for decimal dot test so we are...