Ollie Read
Ollie Read
Hi @jenssegers I'm more than happy to help review, as well as contribute if there's anything specific needed. Apologies for the delay, I've recently moved house.
@jenssegers I'm going through the code, making some adjustments and tidying up, as well as trying to bring a bit more in line with how the core works. You can...
@jenssegers Can I also suggest that you leave some comments for some of the compile methods in the query grammar, for example, `whereSub`, `whereSubIn` and `whereSubNotIn`. I'm not sure what...
@Jamesking56 interesting. In the past I've done this by having an abstract parent repository that does something like: ```php public function getOrSet(\Closure $functionality, ...$arguments) { $hash = generateHashFromArgumentsAndStuff(); $result =...
@rtheunissen I think there were a couple of other methods that did the same, but I just assumed they didn't accept a nullable argument. In terms of wrapping, I'm adding...
@rtheunissen does the splat operator work if args is null/empty?
> Now it is type hinted. Easy to maintain. And not magically hidden in the query builder. It is unfortunately still hidden behind a bunch of magic. More so than...
You could, however, achieve this quite nicely with a macro, but I suspect a PR could be beneficial. If I was just pulling something off the top of my head...
@ludo237 I'd like to avoid storing every claim. The reason for the selected ones above are for several reasons: - `jti` This is the id that represents the JWT token...
You can actually already do this @ludo237 using [custom generation](https://github.com/sprocketbox/laravel-jwt#custom-generation). [This](https://github.com/sprocketbox/laravel-jwt/blob/master/src/JWTGuard.php#L419) is how tokens are generated without a custom generator, so you could just provide your own generation and add...