Olivier Massot comments

Results 8 comments of


                                            Olivier Massot

How to suppress reconnection error?

It would be a useful feature to allow to disable the heartbeat. Mercure allows to do so in the hub config : So if you can disable it in the...

FalViewHelper throw an error when the record is hidden

I use this VH in the backend to display a preview of the carousel images, shouldn't I? I agree on the fact that it's obviously better to directly pass the...

[FEATURE IDEA] Incorporate GIT in Manuskript

a good way to achieve this would be to change the format of the project file (.msk file) to a format like xml. That way you could use the versionning...

To make `assert($mapping instanceof ManyToManyOwningSideMapping)` error more explicit

Done, here is the PR : https://github.com/doctrine/orm/pull/11896

To make `assert($mapping instanceof ManyToManyOwningSideMapping)` error more explicit

@beberlei I'm not sure about the static analysis, but it would certainly be more dev-friendly. In the current state, the dev only receives an AssertionError stating : assert($mapping instanceof ManyToManyOwningSideMapping)...

To make `assert($mapping instanceof ManyToManyOwningSideMapping)` error more explicit

@greg0ire Yeah, you're right :) I was upgrading a legacy project, with hundreds of relations, and encountered this assertion error. I had to resort to using xdebug to find the...

To make `assert($mapping instanceof ManyToManyOwningSideMapping)` error more explicit

@beberlei Oh right, sorry, I just realized what you meant to say, that these asserts were to quiet phpstan or whatever to complaining. Sorry for the hasty reply. Well, like...

To make `assert($mapping instanceof ManyToManyOwningSideMapping)` error more explicit

Done, I've added two unit tests for each of the new exceptions, just waiting for the CI to run