Oleksandr Danylchenko

bug: `IonModal` with `presentingElement` doesn't render on iOS

1

### Describe the Bug When using the ["Card modal"](https://ionicframework.com/docs/api/modal#card-modal) component, we noticed that it _doesn't render_ its content after _switching the viewport orientation_ back and forth: https://github.com/ionic-team/ionic-docs/assets/68850090/63cfd525-0575-4f3c-90e4-4c116b0a0972 Unfortunately, using the...

## Issue `Annotator` type is a public API of the library: https://github.com/annotorious/annotorious/blob/adc3f3b793de47731119efc1a35b8c03af2beb8c/packages/annotorious-core/src/model/Annotator.ts#L15-L65 The **_`setAnnotations`_** is a method to add annotations in a bulk way to the store using the provided...

## Issue This PR resolves the #378 issue, by implementing the suggested steps: > 1. Replace the 2 generics `I` & `E` with a single generic for the `Annotator` (like...

## Current State The `AnnotoriousPlugin` is a React container for the A9S-specific plugins that can patch the `Annotator` instance: https://github.com/annotorious/annotorious/blob/adc3f3b793de47731119efc1a35b8c03af2beb8c/packages/annotorious-react/src/AnnotoriousPlugin.tsx#L5-L31 ## Issue Unfortunately, its tight bond with the A9S types...

## Issue This PR is a follow-up of the #374. I faced the issue with using a `TextAnnotator` with the `useAnnotator`:  That's because: > the `TextAnnotationStore` doesn't fully extend...

## Current State Currently, the `AnnotoriousPluginProps` receives the `plugin` function argument that returns the `{ unmount: ... }` object: https://github.com/annotorious/annotorious/blob/adc3f3b793de47731119efc1a35b8c03af2beb8c/packages/annotorious-react/src/AnnotoriousPlugin.tsx#L5-L11 ## Issue Could we rename the `unmount` to `destroy`? Seems...

`DNS Server failed: listen tcp 127.0.0.1:9253: bind: address already in use` error when starting the app with `puma-dev` command

3

I have the `~/.puma-dev` folder config where one of the entries points to the folder with the app. So it automatically starts on ports `:80` and `:443` under `webtexts.localhost` domain:...

Unmemoized `AnnotoriousContext` state forces too frequent re-renders for its children

4

## Issue By default, w/o memoization, React makes all the children that read the context's state re-render [upon any change](https://react.dev/reference/react/useContext#optimizing-re-renders-when-passing-objects-and-functions). That what's happening rn for `AnnotoriousContext.Provider`: https://github.com/annotorious/annotorious/blob/e112aee1064f8c4f6fe7225a7bc5656d5ea019b2/packages/annotorious-react/src/Annotorious.tsx#L97-L106 When I select...

## Issue Unfortunately, there's no straightforward way to use the `forwardRef` with the generic props. An extensive explanation on _why_ can be found here - https://stackoverflow.com/a/58473012/10963661. Using the generic within...

Should the `openseadragon` be made a required dependency?

6

## Issue Currently, the `openseadragon` **is required** to be present to bundle the `@annotorious/openseadragon` and the dependent `@annotorious/react`:  However, the `openseadragon` is described as _an optional peer_: https://github.com/annotorious/annotorious/blob/e6a5ad1bbebc3fd2eeda343ed265490e4047dd48/packages/annotorious-react/package.json#L35-L44 Which...