Oren Leiman
Oren Leiman
@avikivity @elcallio Thanks for the review! I will rework this a bit and circle back.
force push after rebase to pull in `rpc_test` fix
Hi @avikivity and @elcallio - thanks again for the reviews. Any remaining concerns on this PR?
[force push](https://github.com/scylladb/seastar/compare/6b7304eeba4ee416b352d6a68d870b2f3b38a067..ae37fcb2a7e15102fb7dabdd495f7951f4d611fe) to express `cert_info::serial` as more explicitly a buffer of `uint8_t`.
[force push](https://github.com/scylladb/seastar/compare/ae37fcb2a7e15102fb7dabdd495f7951f4d611fe..1611333694a1d04d77870a27b2a7811f87c298e2) with review comments - cert_info accessors now throw - revert to `sstring` for delivering serial number bytes
[force pushes](https://github.com/scylladb/seastar/compare/e384b4a7ef004b402a47ae1b01e6333b9c38624a..ed2d02125672732258ff55968139644400855041) contents: - replace `sstring` with `std::vector` for raw serial number representation - move previous review ask to correct commit
CI Failures: - https://github.com/redpanda-data/redpanda/issues/16540
[force push](https://github.com/redpanda-data/redpanda/compare/df02347abc61a082e094bc7ae2015c2f8e2ad833..7e76110d626409883bfd4c5b6bd2a41dcc2c5355) contents: - remove unnecessary check on btree_map::emplace result at probe construction - try to account for the possibility of transform retries in tests - typos, etc.
/ci-repeat 5 skip-unit dt-repeat=50 tests/rptest/tests/data_transforms_test.py::DataTransformsLoggingMetricsTest
/ci-repeat 5 skip-unit dt-repeat=50 tests/rptest/tests/data_transforms_test.py::DataTransformsLoggingMetricsTest