Oleg Andreev

Results 107 comments of Oleg Andreev

I'm posting a **2 btc** bounty for refactoring tests into XCTest target and rewriting all of the them in Swift. Tests in Swift will allow us to better feel how...

@rsmoz i mean a new target, for XCTests. The old target and its "+Tests" files should go away.

See [Chain-iOS](https://github.com/chain-engineering/chain-ios) project to see how to configure Swift tests for both iOS and OSX frameworks. There were some caveats in search paths and other settings to make it work,...

I don't see much added value of RSpec: asserts are fine by me (and I prefer using minitest in Ruby since it's in stdlib). The biggest benefit of migrating from...

1) `Tests.swift` (e.g. `BTCAddressTests.swift`) 2) Swift 1.1. When 1.2 is out we'll re-decorate ObjC with nullable/nonnull and update the tests accordingly. CoreBitcoin should never require beta Xcode/SDK to run, only...

Wow. I'll have to check myself when i have time. As for "assignee", i can't add anyone except myself. Is it because it's a personal account (or I don't know...

@rsmoz see what i've done up there in the first comment. Is it fine?

@rsmoz haven't checked your commit yet, sorry (a very busy week). Meanwhile, Xcode 6.3 with Swift 1.2 is out, so we can target Swift 1.2 exclusively. See also https://github.com/oleganza/CoreBitcoin/issues/47

@rsmoz yup, I've made a minimal version of your patch to fix the paths (but haven't added new targets). Only fixed the paths and added Security.framework dependency to make OSX...

@rsmoz here i'd name them `testEmptyUnspents` and `testNonEmptyUnspents`. In other cases when it's hard to have a nice self-explanatory name i'd go with `testSomething1` and `testSomething2`.