Raymond Chen comments

Repositories
Issues
Comments

Results 3 comments of


                                            Raymond Chen

Should SF.7 be less specific on how the namespace is modified, ban other mutations in .h files?

I interpreted the rule to mean more generally "Do not pollute shared namespaces (such as the global namespace)." Importing names into private namespaces is fine (that's why they're private), but...

[Feature] x:Bind should support general string indexers without interface in C#

As noted in the documentation, the collection must be mutable. But your indexer is read-only. > (Note that `IReadOnlyDictionary` and `IMapView` do not support the indexer syntax.)

System menu for Terminal shows up on wrong monitor

Okay, I see what's going on. You are [manually showing the system menu at the upper left corner of the GetWindowRect](https://github.com/microsoft/terminal/blob/c9e993a38ec04833e15edac230300948a0fab83b/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1822) and didn't take into account the fact that [maximized...