Ondrej Ščecina
Ondrej Ščecina
I'm very well aware of following statement from documentation > If the git branch or tag name contains a slash (/), then the label in the HTTP URL should instead...
How to reproduce 1. Given branch=feature/foo tag=foo 2. Send following request to Config Server `/application/default/foo` 3. `JGitEnvironmentRepository.containsBranch` returns true because `refs/remotes/origin/feature/foo` ends with `/foo` 4. `checkout.call()`, line 468 throws `RefNotFoundException`....
> If you have a branch and a tag with the same name how do we know which one we should be using? In this case yes. We could say...
I’m taking vacation but when I come back I’ll have a look.
Just so we understand each other. I have valid **branch=feature/foo** and **tag=foo**. Has Spring Cloud Config been designed to fail when I use **valid** tag name? Has `containsBranch` method been...
> But the wrong returns will not cause any problem Sure it does. There would be no `RefNotFoundException` exception, should it return `false`.
In my case exact match solution would work. @ryanjbaxter Branch is not really an issue. And like @woshikid’s said origin is hardcoded all over the place so at the moment...
Saying that I prefer non-regex solution for performance and security reasons as well.
/attempt #655 https://github.com/permitio/opal/pull/662 Options Cancel my attempt
@Abiji-2020 Still waiting for @obsd to help us with failing tests on #662