David Anekstein

Results 40 comments of David Anekstein

@bluss what can I do to help with that. I noticed there was a call for help some time ago and see some ideas on one of those linked issues,...

> I don't have much time for petgraph. That means help is certainly needed. Fair enough, is that a directive to simply begin rewriting it and submit a PR, or...

I think some sort of file format that can be parsed into something like `*shapes` argument along with shared indices among tensors would be perfect; it doesn't need to be...

> Is your initial thought to easily load 'hmetis' files to find contraction orders for, or are you wanting to try hmetis itself as a hypergraph partitioner? More the former,...

> Have you tested the new AddrOfLocal handling on code with loops or other interesting control flow? No, I will add more snapshot tests for those cases and update you...

> What does this PR do? Could you update PR title and add a brief description? Will do soon, will definitely have it by the time I mark it ready...

> Okay, great. I wasn't sure since @spernsteiner already approved. Yeah, I won't be merging until I have approval for the PR generally. That was just for the snapshot.

> Is there a way to split this PR up more? It's getting quite big. The formatting changes in pointers.rs can at least be done directly to master; I've been...

> Also, after https://github.com/immunant/c2rust/pull/637 landed, we have a release snapshot in addition to the existing debug one, so can you add the updates to that one here? Done

@fw-immunant @kkysen i've squashed things into one commit and will split it up from here, that seems easier than approaching it from the opposite direction