Olivier Gayot

I'm curious, what are the consequences of assigning to _ in this context? is it breaking something? We have other existing assignments too: ``` console_conf/controllers/identity.py: key, _, value = line.partition("=")...

> _ is how we do translations. Right, but - does it break translations when we use `_` for other purposes ? - is what I meant. If it does,...

> > Right, but - does it break translations when we use `_` for other purposes ? > > In this case, no. > > I realized yesterday that I...

Fixed wrong behavior caused by unused `for_field` variable. The variable was meant to be used of course. Thanks @dbungert for noticing!

> > It also makes the confirmation mechanism usable without using fields with hard-coded names. Yay! Maybe we might use it for email + confirmation email some day? > >...

> I guess I agree that having it as an argument to the field doesn't really make sense (although you can pass the field itself, you don't have to pass...

> > I guess I agree that having it as an argument to the field doesn't really make sense (although you can pass the field itself, you don't have to...

~~I noticed this PR addresses a failure in integration tests when we attempt to fetch an SSH key but fail to contact github/launchpad. The SSH client controller does not open...

> > I noticed this PR addresses a failure in integration tests when we attempt to fetch an SSH key but fail to contact github/launchpad. The SSH client controller does...

> It would be nice if we could avoid bugs where we call remove_overlay when we shouldn't but this is pragmatic I guess! Agreed! That's what https://github.com/canonical/subiquity/pull/1315 was about, really....