Ola Flisbäck
Ola Flisbäck
That sounds interesting, is there some part of it that can't be accomplished already from the client side considering that you can set alert fill and text color?
Ok, in my mind it's better to keep this out of the library, I just don't feel that it adds enough convenience.
The way react-favicon adds the icon link(s) doesn't seem to work in Safari anymore, a suggested fix would be very welcome. Interestingly the favicon isn't shown for other major sites...
I'm sorry to say that I'm not looking into this, but I'd be happy to try out and merge a PR to address it.
I have signed the CLA now.
Hi @NathanKoehler thanks for taking the time to do this, it looks useful. Please use prettier to format the code in the PR and if you are up to it...
Hi @NathanKoehler, the big changes I mentioned have been merged, I'm sorry that it made the merge of this PR harder. If you'd like to give it another go please...
The fork has been updated and I verified that building works, also if there's a problem building there now is a published github release of the obsidian-local-rest-api you can use...
Thanks a lot for reporting this, I have reverted the offending commit to investigate offline, there's a new `2.0.5` version published.
Thanks for reporting and for the minimal config suggestion, I hope it doesn't matter because I'm not using the exact same config when I try this (I don't have `custom.obsidian_opts`)....