Ofer Bartal comments

Results 54 comments of


                                            Ofer Bartal

MessageDifferencer ignoreFields doesn't work for RepeatedFields.

We just forked the code in truth. Can you put this issue on the truth repo? https://github.com/google/truth

MessageDifferencer ignoreFields doesn't work for RepeatedFields.

Indeed, looks like it was deleted: https://github.com/google/truth/commit/b00942127329c8ff8f9587a391c0b610f764efc1

MessageDifferencer ignoreFields doesn't work for RepeatedFields.

Perhaps this is the new differencer? https://github.com/google/truth/blob/master/extensions/proto/src/main/java/com/google/common/truth/extensions/proto/ProtoTruthMessageDifferencer.java

Remove the slf4j-simple dependency, as we use Flogger

I agree. Can you give an example of what you'd like to see, or specific features that are missing?

Remove the slf4j-simple dependency, as we use Flogger

We already use Flogger throughout: https://github.com/google/startup-os/search?q=com.google.common.flogger.FluentLogger&unscoped_q=com.google.common.flogger.FluentLogger

Remove the slf4j-simple dependency, as we use Flogger

So that's a good question, some of our dependencies from Maven need it. Not sure if there's anything we can do about that.

Remove the slf4j-simple dependency, as we use Flogger

Ok, I now remembered why I didn't completely removed the dependency on `slf4j-simple`. When I tried, I got these pesky logs every time I ran something. I just tried it...

Remove the slf4j-simple dependency, as we use Flogger

Thanks for researching this! Taking a little step back, do we want to replace JUL with log4j2/logback? If so, why? :)

Remove the slf4j-simple dependency, as we use Flogger

Ok, got it! So until we have a reason to use one of the other backends (other than to potentially remove the dependency on `slf4j-simple`), I'm moving this to P3....

Folder structure for packages and Java

Do you mean that, `com.google.startupos.tools.reviewer.aa.AaTool` is in folder `tools/reviewer/aa` instead of `java/com/google/startupos/tools/reviewer/aa` and tests in `javatests/com/google/startupos/tools/reviewer/aa`?