Rob H comments

Repositories
Issues
Comments

Results 3 comments of


                                            Rob H

Memory leak when using Task#with_timeout

We have tested the changes to the timers gem and while they do appear to remove the accumulation of `Timers::Timer`, there is still a memory leak in our code (which...

`Async::Queue#signal` does not default `value` to `nil`

I can make a PR, but it feels to me like the semantics of the `#signal` method have fundamentally changed, so I'm not sure I fully understand the expected behaviour....

`Async::Queue#signal` does not default `value` to `nil`

Confirmed, it looks like v2.3.0 which includes the changes in #187 fixed our issue, and we just haven't checked since then. So we can just remove the `#signal` call completely....