Omar Elhawary

Results 27 comments of Omar Elhawary

It sounds like a good default to be added in `generouted`, thank you for bringing that up. Also seems pretty straight forward to filter out private paths, will try to...

IMHO the separation between routes and components makes it more clear. I like the idea to support co-locating page related components as it might be handy and expected but it's...

This is a related opinion/take 😄: https://mobile.twitter.com/delba_oliveira/status/1586666502039691264

Quick update, supporting co-locating non-pages files inside `pages/` directory with `_` prefix was added here https://github.com/oedotme/generouted/commit/87ed45417f0882d2fae058401c4a65d13fc9d9d2. Another related update, `_layout.tsx` is also now supported (similar to Expo router and Next.js...

There's a workaround by aliasing `react/jsx-runtime.js` to `preact/jsx-runtime` in `next.config.js`. You can find an example here https://github.com/kentcdodds/mdx-bundler/issues/140#issuecomment-1013928307 on a similar issue I opened recently.

@jfairley I've excluded the ignored files/directories from Vite's glob pattern and that did that trick to exclude the ignored routes from the production build bundle. It's now released at [v1.19.3](https://github.com/oedotme/generouted/releases/tag/v1.19.3)!

That's interesting! Could you share that via StackBlitz for example? I'll be happy to have a look into that. I was also thinking recently to store current modal as a...

I think this example https://github.com/oedotme/generouted/tree/main/examples/react-location/modals might be using a similar approach to what you're referring to. Basically to have an outlet and a child modal component, which gets mounted on...

@archiekd modal routes can be achieved with **route layouts** + **certain structure** + **just links** and can be done with or without `generouted`. It's different than the existing global modals...

@Zombiefruit I can see that the generated types, specifically those share the same beginning like `/dashboards/${string}` would also match for `/dashboards/${string}/${string}`, `/dashboards/oops/${string}/${string}/oops`, etc: ```ts type Path = `/dashboards/${string}` const segment...