Odin Holmes

LPC11xx_v6.svd has multiple enumerated values with the same name

4

So far we have been correcting names of things in extention files in order to not mess with the SVD (in order to stay open to drop in improvements from...

Inheritance not fully defined

5

I'm having trouble interpreting effects of the derivedFrom tag. It is not clear to what granularity tags in the derived ovject override tags in the base object. For example here...

No support for inheriting tags

4

Tags like `derivedFrom` or `size` etc. affect children further down the tree. In order to implement support for them we need to either do a second pass through the parsed...

How to deal with double tags?

4

In MKL25Z4.swd: ``` xml CM0PLUS r0p0 little false false false true 2 false ``` `mpuPresent` is defined twice, how should we handle stuff like this generally? Here we can ignore...

svd files do not have enough info

11

The bit fields of a Register can have odd behavior. An example is a bit acting as a hardware flag where the hardware can set it and the software can...

Vendors use enumeratedValues in odd ways

6

http://www.keil.com/pack/doc/CMSIS/SVD/html/group__svd__xml__enum__gr.html states that enumeratedValues::enumeratedValue::value "Defines the constant of the bit-field that the name corresponds to.", however some svd files like https://raw.githubusercontent.com/posborne/cmsis-svd/master/data/Freescale/MKL27Z4.svd define enumerated values like this: ``` xml PDDR Port...

atomic queue not always atomic

4

https://github.com/roboterclubaachen/xpcc/blob/develop/src/xpcc/architecture/driver/atomic/queue_impl.hpp#L132 I assume the queue is single producer and single consumer (doesn't say so in the docs but judging by the implementation). Even so there are potential problems in the...

Suggest naming prefixing all unsafe member functions with unsafe

1

Here https://github.com/roboterclubaachen/xpcc/blob/develop/src/xpcc/architecture/driver/atomic/container.hpp#L158 atomic::Container provides an unsafe function, which is perfectly usefull and ledgitimate. However there is a convention of prefixing all function which violate assumed constraints with 'unsafe' as in...