Christian comments

Results 5 comments of


                                            Christian

nx.lowest_common_ancestor incorrectly returns None for this DAG

**TL;DR**: I have so far not found a bug in the code compared to the paper's algorithm. Just following the algorithm from the paper, I already encounter this problem. I...

nx.lowest_common_ancestor incorrectly returns None for this DAG

I believe, the algorithm in NetworkX was originally implemented by @calmofthestorm. Even if it was quite a while ago, maybe he can offer his opinion on the matter :)

nx.lowest_common_ancestor incorrectly returns None for this DAG

Thanks for your response! Intuitively your approach of creating one spanning tree per source makes sense. This guarantees that the two query nodes are always contained as a pair in...

nx.lowest_common_ancestor incorrectly returns None for this DAG

@calmofthestorm I am not quite sure. The [code](https://github.com/jeremy-murphy/graph-ancestry/blob/master/lowest_common_ancestor.hpp) contains a description that includes DAGs. But I cannot find the actual implementation of the function `lowest_common_ancestor_query`. @dschult: You are right that...

[BUG]: stl_bind generates invalid type signature for Sphinx/Pylance

The current naming with e.g. `KeysView[BindedMap]` also prevents formatting the stubs with black, because it stumbles on the IMO incorrect Python syntax. Is there a reason against a name with...