Nadav Zingerman

Results 7 issues of Nadav Zingerman

### Describe the bug SQLAlchemy 1.4 will set `Sequence.start` to `1` if it is `None` during `compile()`. This is incorrect because the sequence may have a `minvalue > 1`, which...

bug
sql

It is possible for `inferring_router` to raise an exception if a function uses a return type that is not a valid `response_model`. An example is an endpoint that returns `Response`...

### Describe the bug I have a GitHub actions that runs `gh pr edit` using the `GITHUB_TOKEN` created automatically for the job. When I added ```yaml permissions: pull-requests: write ```...

bug
p2
gh-pr

I was confused about when exactly `allow_reuse=True` was required, so I looked into the implementation. As far as I can tell, the motivation behind the feature is outlined in https://github.com/pydantic/pydantic/issues/312#issuecomment-449875744....

deferred

This PR fixes a few things with the repo's pre-commit hooks: * `files` regex - escape `.`. * Add `files` to `poetry-lock`, so that it doesn't run on every commit...

status/needs-consensus

Previously, using parameterless `Depends()` in a generic context would bind the dependency to the first encountered concrete type. Fixes #9450.

feature

When I tried to pass a `float` for `receive_timeout` in `Connection`, I got an error: ``` ldap3.core.exceptions.LDAPMaximumRetriesError: LDAPMaximumRetriesError: LDAPMaximumRetriesError: restartable connection strategy failed while opening socket/Exception history:/ 0 : required...