Nicole Feng

Results 11 comments of Nicole Feng

I hope that fixes it... thanks, Nick, for being patient with my first couple contributions to Polyscope :)

> Is this a blocker for the course? Or just something that would be nice to have? Nope, just something that would be nice to have!

Seems good to me! Thanks for doing this! (Too bad shaders have limits on the number of attributes. But I suppose that it's a sign of Polyscope's ever-increasing maturity.)

Yes, it's good to go on my end! Edit: Just rebased on top of geometry-central's `master` branch.

Hope late is better than never :). You can do something like ``` Face commonFace = sharedFace(p1, p2); SurfacePoint pA = p1.inFace(commonFace); SurfacePoint pB = p2.inFace(commonFace); SurfacePoint midpoint(commonFace, 0.5 *...

Hi, thanks for sharing! Usually one sets debugging modes via compilation flags, rather than hardcoding it directly. In these exercises, by default, just compiling using `cmake` (i.e., without explicitly setting...

By the way, thank you for sharing this. Now that I think about it, it makes more sense to make the default mode "debug" rather than "release" for these exercises....

@MarkGillespie or @nmwsharp, adding this support for polygon meshes required making some changes for `EmbeddedGeometryInterface` --- mainly removing the asserts that assumed triangular faces in functions like `computeCornerAngles()` and `computeFaceAreas()`....

FYI this PR also updates the `cornerAngles` issue mentioned [here](https://github.com/nmwsharp/geometry-central/issues/214#issue-3066729414).

I've squash-merged for now! 🤞