Nadav Har'El

Results 95 issues of Nadav Har'El

In commit 3c095cd66f8dbd33ef10abbc6ed425103fe7d96c, @denesb added a `on_internal_error_noexcept` function. Whereas the regular `on_internal_error` is `[[noreturn]]` - it always crashes or throws - the "noexcept" variant is **not** `[[noreturn]]`. Depending on the...

In some cases, once a certain problem occurs, it can occur thousands of times in quick succession, and flood the log files with identical (or at least similar) messages. The...

When an HTTP server receives a completely malformed request, e.g., "hello" instead of "GET / HTTP/1.0" or similar, it should return error code 400 (Bad Request). https://tools.ietf.org/html/rfc7230 says this: >...

http

While trying to make advanced usage of Seastar's HTTP server's mechanism for specifying the content-type header in the response I realized it is a mess: 1. `reply::set_content_type()`, despite its rather...

enhancement
http

In the Scylla project we often print exceptions using Seastar's logging. Here is an example error message, where the entire text in bold is one exception: > ERROR 2022-03-21 14:33:13,657...

enhancement

A user complained in https://groups.google.com/d/msg/scylladb-users/jWkYesNzz_g/Dcxkgt--CgAJ that he can't run a Seastar program with "--memory 512M" on a 2GB machine, getting the cryptic error message: ``` FATAL: Exception during startup, aborting:...

Currently, Seastar exports metrics using the Prometheus protocol. This is an extremely wasteful textual protocol, which repeats long variable names and user-readable help strings again and again, and also sends...

enhancement
metrics

Anh Dũng Phan reported on [this mailing-list thread](https://groups.google.com/g/seastar-dev/c/9jNZ5xbDVdw/m/DY64hjPTAAAJ) a bug in Seastar's native TCP stack's handling of the congestion window. In `include/seastar/net/tcp.hh` in the `can_send()` function, we have: ```c++ //...

bug
tcp/ip

HTTP/2 added a number of interesting features beyond HTTP 1.1, such as request multiplexing and header compression. It would be good if Seastar's builtin HTTP server implementation, which is currently...

enhancement
http

According to a ClangBuildAnalyzer report on a build of the Scylla project, the Seastar `` header had a huge cost for the build time of the project: Most of the...

build