Neal H. Walfield

bz_internal_error exported

1

I develop [`rpm-sequoia`](https://gitlab.com/sequoia-pgp/rpm-sequoia), which is a Rust crate that implements [rpm's OpenPGP API](https://github.com/rpm-software-management/rpm/blob/master/include/rpm/rpmpgp.h) in terms of [Sequoia PGP](https://sequoia-pgp.org/). (More details, unrelated to this issue, are described in [this rpm issue](https://github.com/rpm-software-management/rpm/issues/1978))....

Adding collision detection

6

Like it or not, SHA-1 is still used in practice. In [Sequoia PGP](https://sequoia-pgp.org), we initially decided to bad list SHA-1. However, a developer of Secure Drop recently approached us and...

Documentation for hir::Repetition is misleading

5

Consider the [following code](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=d1dac0793d5b6fc8970f132ad18a2f54): ``` use regex_syntax::hir; fn main() { // Is this: xab+y or x(ab)+y? let xabplusy = hir::Hir::concat(vec![ hir::Hir::literal(hir::Literal::Unicode('x')), hir::Hir::repetition(hir::Repetition { kind: hir::RepetitionKind::OneOrMore, greedy: true, hir: Box::new( hir::Hir::concat(vec![...

WIP: Improve documentation

3

I found it very hard to get started with capnproto-rust. In particular, it was unclear to me how to send complex RPCs, and how to process RPCs on the server....

feature request: ahash without length prefixing

3

In Sequoia, we currently use `xxhash` to compare streams. [`ahash` appears to be better than `xxhash`](https://gitlab.com/sequoia-pgp/sequoia/-/issues/1074), because, as discussed in your README, it is faster, and it is already used...

Consider padding messages

1

https://github.com/freedomofpress/securedrop/blob/6da5239fa1531a79dcf02693a97e4662b51401da/redwood/src/lib.rs#L158-L164 Sequoia supports padding at the OpenPGP layer using the [`Padder`](https://docs.sequoia-pgp.org/sequoia_openpgp/serialize/stream/padding/struct.Padder.html) filter. It's a bit of a hack and not all OpenPGP implementations are able to handle it, as [this...

Code a (tiny bit) brittle

1

https://github.com/freedomofpress/securedrop/blob/8d00ba5d9d3835a22a09bcd3a338b65aee697e7d/redwood/src/decryption.rs#L51-L68 The above code is a bit brittle in principle, but probably okay in practice. The problem is that just because we fail to decrypt a PKESK doesn't mean that...

https://github.com/freedomofpress/securedrop/blob/8d00ba5d9d3835a22a09bcd3a338b65aee697e7d/redwood/src/lib.rs#L37-L38 `NoSupportedKeys` is only instantiated in the keys module and [it means no usable keys](https://github.com/freedomofpress/securedrop/blob/develop/redwood/src/keys.rs#L28-L34). A key may be supported by the cryptographic backend, but it may be that it...

Consider having and enforcing a commit signing policy

5

## Description Looking at the SecureDrop code, I see that many commits are signed. That's great! But, I couldn't find a signing policy. This makes the signatures less useful. Anyone...

Don't show global options

4

### Please complete the following tasks - [X] I have searched the [discussions](https://github.com/clap-rs/clap/discussions) - [X] I have searched the [open](https://github.com/clap-rs/clap/issues) and [rejected](https://github.com/clap-rs/clap/issues?q=is%3Aissue+label%3AS-wont-fix+is%3Aclosed) issues ### Clap Version 4.5.0 ### Describe your...