Nicholas Volker

Results 14 comments of Nicholas Volker

@iloveitaly can you provide links to examples of where you have done this? That way I can conform to the same approach taken. Then I'd be happy to do so...

As suggested by @arielvalentin, [here](https://cloud-native.slack.com/archives/C01NWKKMKMY/p1652105932838119?thread_ts=1652103347.480239&cid=C01NWKKMKMY), using ENV variables works as expected as this pulls this is pulled in separately from the user-supplied configuration: ```ruby export OTEL_RUBY_INSTRUMENTATION_RACK_CONFIG_OPTS="untraced_endpoints=/health" ``` > https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/base/lib/opentelemetry/instrumentation/base.rb#L272

Just checking why Ruby 3.1 is sad with me: ``` 1) Error: OpenTelemetry::Instrumentation::Resque::Patches::ResqueJob::#perform::force_flush::true#test_0001_does forcibly flush the tracer: MockExpectationError: No more expects available for :force_flush: [] {} /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/resque/lib/opentelemetry/instrumentation/resque/patches/resque_job.rb:60:in `perform' /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/resque/test/opentelemetry/instrumentation/resque/patches/resque_job_test.rb:229:in `work_off_jobs'...

@fbogsany, @ahayworth would either of you mind approving the running of the workflow? 🙏 As per the commit comment ([b8eb97e](https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/117/commits/b8eb97eab75cb61d788d8f0b73ae027789c98808)), I believe this has resolved the flakiness. I ran it...

> CI runs approved (I thought I did that already, weird). My new commit is likely the culprit. Perhaps you have to approve CI each time?

Oooof. The `Minitest::Mock` is still not working out for me on Ruby 3. I tried giving each scenario its own mock to try to combat this flakiness, but at this...

+1 on this. Tagging documents is awesome for search and categorization :)

Awesome! Looking forward to this one 🥇

I'd like to get involved 🖐️