Nicolas Velasquez

Results 15 comments of Nicolas Velasquez

Thank you for the update and for the workaround 👍 Looking forward to version 2!

@adriangb I couldn't see "pd.Timestamp" used in your test code. Did I miss something? Here is a bunch of tests against V2: - [Tests with V2](#tests-with-v2) - [Same code as...

We are running into this bug too. The workaround (use profile mysql-redis) works, but it feels considerably slower than postgres-redis. We currently have: 4164 engagements, 121174 findings, 30046 endpoinst and...

@impredicative, There is no harm, but using the "raw" flag I would expect a "RFC-3339 formatted timestamp with nanosecond precision".

@impredicative Well, it seems that msgpack supports strings: https://en.wikipedia.org/wiki/MessagePack. I'm no expert thought. Note that the RAW flag for the timestamp field is also ignored in the historical API calls...

Yeah, I had come to the same conclusion some time ago: I've been using my own client for months. However, I believe it is important to fulfill the flag expectations!...

@impredicative I am not arguing that a string representation of a date is better than a "date data type"! I am simply saying that functions should behave as expected, given...

That's fair. Should I open a separate ticket for the "Historical Stock Pricing Data" endpoint?

> Would you mind adding a unit test [here](https://github.com/DefectDojo/django-DefectDojo/blob/master/unittests/tools/test_qualys_parser.py) with an example file that triggers the bug you mention, in order to validate this fix and ensure we don't have...

@mtesauro I added the unit test. Additional changes follow the logic of https://github.com/DefectDojo/django-DefectDojo/issues/6248#issuecomment-1164293652. Pull severity from 'SEVERITY' field in source XML, if not available, try to extract it from CVSS_VALUE...