Nahshon Unna Tsameret

Results 25 issues of Nahshon Unna Tsameret

Was trying to use this action in my workflow. It keep failing with "Not Found" error: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1176/checks?check_run_id=2076631480 ``` Error: Error setting status: Not Found Request object: { "context": "sanity-test", "description":...

help wanted

Originally done at #8016 Limit the maximum file length to 1500 lines in the tests package for now. One exception for `tests/utils.go` and `tests/reporter/kubernetes.go` exists. `pkg` and `staging` are excluded...

size/L
release-note-none
needs-rebase
lgtm
dco-signoff: yes
sig/code-quality

Some of the underline custom resources are getting changed as part of the upgrade process. This causes HCO to increase the `overwrittenModifications` metric, while this is not a user action....

release-note-none
size/M
dco-signoff: yes
lgtm
approved

For CDI/KubeVirt new DV GC is configurable via CDIConfig (`DataVolumeTTLSeconds`). Currently disabled by default, but CDI plan to enable it by default Upon the release of the next CDI version,...

lifecycle/stale
kind/enhancement

Add the `dvbuilder` package in order to build DVs for functional tests. `dvbuilder.NewDataVolume` is a manufacture for a `DataVolume`. The `NewDataVolume` function a list of `dvOption`s. The current options are:...

size/XL
release-note-none
lgtm
dco-signoff: yes
sig/code-quality

### What this PR does Move many VMI validation from the validating webhook, to the CRD, using [OpenAPI v3 schema](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#schemaObject) See [here](https://book.kubebuilder.io/reference/markers/crd-validation) for more info. Continue the CRD validation started...

release-note
size/XXL
needs-rebase
kind/api-change
dco-signoff: yes

### What this PR does The tests/utils.go::listCgroupThreads function only used in one place. This change move this function to the file that actually use it. ### Why we need it...

size/M
release-note-none
lgtm
dco-signoff: yes
sig/code-quality

## Bug Report **What did you do?** Deployed an operator using a CSV file. The CSV file contains several `admissionReviewVersions` sections to define webhooks. For each one of these `admissionReviewVersions`,...

kind/bug

### What this PR does NewRandomVMIWithEphemeralDisk is deprecated. This PR removes calls to this function from all test files (except for tests/vmipreset_test.go, that is done in #11826) ### Release note...

size/M
release-note-none
dco-signoff: yes
sig/code-quality

### What this PR does The gomega's `Eventually` and `Consistently` function API is ambiguous. The time interval parameters (timeout and polling) are both optional, and can get multiple values, such...

size/L
sig/network
sig/storage
release-note-none
needs-rebase
dco-signoff: yes
sig/code-quality