nukoseer

I had same problem with the One by Wacom model. I commented out sdl_milton.cc:272(https://github.com/serge-rgb/milton/blob/master/src/sdl_milton.cc#LL272C37-L272C37) and now it works normally. Probably, this is not the right way to fix this problem...

Is there any relation between targets and source files? Idk some kind of a project structure like these 3 source files and this target makes one project etc.. I tried...

Yes, it worked when I disabled access violation exception. Thank you!

> I'm not sure exactly how it should look; highlighting each entire row with its tab color might be too visually loud, but a small indicator in each row would...

@microsoft-github-policy-service agree

@ehoogeveen-medweb At the end dimensions can't be larger than 32767 because there is clamping before calling `SetWindowPos` (https://github.com/microsoft/terminal/pull/17721/files#diff-d9af234d6dd21db9240dc3733d69471898a79f1c4386cb3c48ac45ab7158cd07R728). When both dimensions are 32767, I think the window becomes as big...

Apparently I'm not taking the title bar and tab bar height into account when calculating the window height. I noticed that there is some built-in logic in the `GetLaunchDimensions` function...

> (other than that though, the plumbing on this looks great, and overall I think you did cover a lot of the wacky weird edge cases like the tab row...

- I added `GetNewDimensions()` function in `TermControl.cpp`, it is exactly the same with `GetProposedDimensions()` but it does not get the font size from settings instead it calls `_core->FontSizeUnscaled()` which returns...

I realized there is no need to copy everything from `GetProposedDimensions()` to `GetNewDimensions()`. I removed some parts and made it a bit simpler.