Clément Vasseur

Results 10 comments of Clément Vasseur

Just add a check for the needed ffmpeg symbols in configure, so you don't need to depend on a specific release.

@JDarnley I cannot reproduce this warning with valgrind. Can you provide a sample stream?

> I hacked rist_ts and rist_rx changes to test quickly > > Not sure if I should remove the changes completely or add new programs You should probably add `srt_tx`...

There are still some indentation changes left in `rist_rx` and `rist_tx`.

What about adding `upipe_srt_source` and `upipe_srt_sink` pipes which could be used as replacement of `upipe_udp_source`/`upipe_rtp_source` and `upipe_udp_sink`? These would make `srt_tx`/`srt_rx` much simpler, and srt usage in client applications as...

> I don't understand what they would replace exactly, why does udpsink need to be replaced? The same way you could replace `upipe_udp_source` with `upipe_rtp_source` to use RTP instead of...

Yes, it encapsulates everything, which is why `srt_tx` and `srt_rx` will be much simpler afterwards.

> Maybe once we have fixed the bugs we could have a wrapper pipe? Agreed. It does not have to be in this pull request.

Perhaps the functions in `uref_attr_s12m.h` should validate their input values and return `UBASE_ERR_INVALID` when out of range?

If your extra CPU usage comes from `umem` allocations from the `udict_inline` implementation, perhaps it could be solved by adjusting the `min_size` parameter for `udict_inline_mgr_alloc()`. The default value (128) is...