Nick

Results 51 comments of Nick

Blocked by https://github.com/sandialabs/pyttb/issues/214

I think there is some nuance to the asserts. I think specific exceptions are more helpful for things that couldn't POSSIBLY be correct. However, in [this](https://github.com/sandialabs/pyttb/pull/207) PR I used an...

I find to_* more readable and I think it follows the snake case convention. However I think aligning with numpy is probably the better option at this point.

For gcp_opt we are using the default number of steps per iteration. So max_iters=2 with steps per iteration=1000 is still a lot of steps. Looking at a few problems reducing...

So here is the _terse_ documentation on the LBFGS solver https://github.com/sandialabs/pyttb/blob/6a6f0b70150be0fe2d43cf9301ffb19094664dd8/pyttb/gcp/optimizers.py#L425. Are you saying the LBFGS documentation should be more verbose, or we should be more explicit about gcp_opt controlling...

I believe https://github.com/sandialabs/pyttb/wiki/Development-Plans already has moderate coverage here (in case this wasn't already what you were thinking about).

I saw @jeremy-myers started to work on this already by writing up tables in restructured text (which looks great so far!). I would really like something that fails loudly when...

Zero rush on my side. I was on a variety of flights this week so I was much more active. Just wanted to weigh in to reduce a large refactor...

Not to derail the conversation but if you make a `maxiters` fixture (or some other reasonable name) in conftest.py then it is pretty hard to forget about since it gets...