Natalia Tisseyre

Results 9 comments of Natalia Tisseyre

> Hey @ntisseyre ! Happy to see you here 😄 > > I added some comments regarding this PR, because I don't know the purpose of the changes. I assume...

> I would prefer adding a simple unit test also which tests the new API `tx.multiQuery(vertices).drop()` for better test coverage. Otherwise this PR looks good to me. After this PR...

> Currently I'm stuck on the following two TinkerPop tests: > > ``` > Error: Failures: > Error: org.apache.tinkerpop.gremlin.process.traversal.step.filter.DropTest$Traversals.g_E_propertiesXweightX_drop > Error: Run 1: DropTest$Traversals>DropTest.g_E_propertiesXweightX_drop:98->DropTest.lambda$g_E_propertiesXweightX_drop$1:98 expected: but was: > Error: Run...

> @ntisseyre let me know if you want to review it or I will merge this PR by following lazy consensus Let's merge, thanks @porunov !

> Thank you @ntisseyre for this great contribution! I left some general comments below. However, I have some questions / thoughts. > > 1. What happens if the user uses...

> Benchmark test: LGTM. Added `testIndexInlinePropertiesReindex` test seems to fail for some index backends. When I run this test locally, it also returns unstable results: sometimes it succeeds, and sometimes...

> LGTM. Thank you for this amazing feature @ntisseyre ! @porunov, I have updated the documentation in one of the commits. Please take a look at the `Important Notes on...

> @ntisseyre do you want to merge it or not ready yet? Just asking because I wanted to rebase #4695 after you merge this PR to add inline index functionality...

> Sorry I just saw this. This is awesome!!!! I didn't take a look at implementation detail, but we are essentially implementing covering index, right? That's right, it is like...