Reid Wahl

Results 107 comments of Reid Wahl

@liangxin1300 Are you asking where the meaning is defined or where these attributes are attached to the fence agent? They're attached to the fence agent's attributes in the metadata. I'm...

> The stonith-timeout cluster property is in fact used: It looked that way to me too just from the code. I didn't get around to testing the property, as this...

Replaced commit to address feedback. The main change is the addition of a `Component` class. I also removed the explicit check for executability -- we'll rely on try/except. And I...

I noticed the mode changed from `100755 → 100644` according to the GitHub comparison, since I started with a new file and kept the default permissions. It builds just fine...

> I'm doing a little bit more testing (should be done in 30 mins or so) but I'm hoping not to touch this, except in response to any other feedback....

Minor changes: * Made `TEST_HOME` a constructor param for `Component`, instead of a global var. * Renamed `Component.use_sudo` to `Component.requires_root`. * Added `cmd` to `Component` class docstring. * Corrected type...

New push just moves `USAGE = 64` to its own line (https://github.com/ClusterLabs/pacemaker/pull/2806#discussion_r951460694).

TL;DR, this seems to be fine. See the edit at the bottom. --- There is one issue with this that is a quasi-regression, and I'm not sure if there's any...

EDIT: Regarding the below, I decided to drop all the `partial_activation` stuff from this PR. We can deal with it separately. There are already a lot of changes here. I...