Nick Reid

Results 61 comments of Nick Reid

If it's infeasible to update the actual property declaration to be a simple assignment, it would also work to declare the property separately. Something like `/** @type {!Quaternion} */ Object3D.prototype.quaternion;`...

How can `Quaternion extend Object3D`? Since the constructor of `Object3D` instantiates `Quaternion`, that would cause infinite recursion. More to the point though,`/** @type {!Quaternion} */ Object3D.prototype.quaternion;` could be added anywhere...

Depending on what the warnings are, you could just `@suppress` them. That's our standard approach to rolling out new diagnostics. The code works today, so the warnings likely don't correspond...

Just want to add, the compiler recognizes properties creates by `Object.defineProperties` during optimizations, but not during typechecking. As such, we believe things are working as intended. That distinction might feel...

Do you have a suggestion on what a better behaviour would be? Our understanding is that another tool in your build is modifying the content of a file between two...

Ahh ok, so there's a real bug here when the input code comes with a sourcemap, we're indirecting through that first sourcemap in an unsafe way when building our own...

After some digging, it's now clear that the underlying issue is that we never imagined that multiple inputs could have the same filename. That's happening here, because one of the...

There was a delay in the NPM release that we didn't realize. This might be fixed now.

What externs are you using? `Object.getOwnPropertyDescriptor` needs to be defined in externs and annotated with `@nosideeffects`. The "canonical" externs do this, but I can't tell if those are part of...

This is a known issue. Type resolution is broken with respect to forward-referenced, templated, ancestor types. There's no place where it attempts to connect the template map from such an...