Maggie Nolan Edmonds

Results 37 comments of Maggie Nolan Edmonds

Per our [CONTRIBUTING.md](https://github.com/google/pprof/blob/master/CONTRIBUTING.md#what-to-expect), two of the main things that are considered when deciding if a PR for a new feature should be accepted: * The tests added in the PR...

I would have some hesitations about the maintainability of a test case which uses a mock for `llvm-gsymutil` when there are no tests which confirm the integration WAI, since that...

First part (changing the order of browsers) is fixed with #392.

Updatinge here #392 was rolled back to fix #402 (using "xdg-open" as the default resulted in `pprof- web` opening the graph in the default SVG viewer; tooltips and panning do...

Thanks for the profile! @filipesilva - Another follow-up questions: Which version of pprof are you using? (Either the commit hash if using pprof from this repo, or the go version...

Thanks! The version of pprof from the head of this repo is being used. This might be a Windows-specific issue.

Tag being displayed could be noted in legend as "nodelete tag" or something similar.

This is a good feature request. It's a bit tricky for two reasons. First, `pprof` represents profile comparison by subtracting one profile from the other; flame graphs don't really work...

I'm able to reproduce the TestObjFile failure on a Centos 6 GCE instance. Haven't been able to reproduce other test failures.

+kalyanac@ -- I think you'd have the most context for the `-disasm` output right now.