Ryan Tinianov

Results 7 comments of Ryan Tinianov

Sorry for the delayed response. JDBCStore function storeSequenceNumbers line 278-282 (copied below [1]) update both sequence numbers, but the lock taken in Session are only for one of the sequence...

> I have change my mind, I don't think there is a bug. > > There was a change to the memory model back in Java 5. Synchronization actions, like...

> hehe, I have changed my mind again ;) > > I believe you are correct. When the sender thread acquires the `senderMsgSeqNumLock` we have what the Java spec calls...

> Why do we have to avoid the standard testing framework in order to execute against real chains? These seem like separate concerns. The tool it's being used with isn't...

> hey @nolag , thanks for this PR! I'll try to review it asap. In the meantime can you rebase it and resolve the conflicts? thank you! Done, I rebased...

Not sure if I'll get to your comments this week or not, but I'll share some thoughts for now. > 1. the generated code for enums in the tests seem...

> @nolag ok for pts. 2 and 4. pt 1 should probably be fixed and covered by a test that exercises the generated code (I started introducing them, but they...