Josh Stewart

Results 164 comments of Josh Stewart

> The best way to reduce the risk of corruption is to call file.sync() at key points in the program. Are calls to `file.sync()` blocking or slow such that these...

I'm struggling to see the benefit here of knowing the number of pulses in a revolution. The existing code already samples over a certain number of teeth (4 by default)...

Boost control using MAP as a load source can be very problematic and is why it has never been included before. When you change the boost control, you're altering the...

> > why can't you make the voltage divider do 0-5v instead? > > Can do, the top resistor has to be decreased & that means there will be more...

Note that currently TuenrStudio doesn't allow you to add `#defines` from within a `#if` conditional, so this can't easily be changed based on the project setting. Will have to try...

I've added comments for a few things I've spotted whilst reviewing this, mostly where something is fundamentally changed from the current functionality. Have tested through some of the most common...

@TBAMax Re-reading my comment from the other day and I realised it probably came across a bit negative. Wasn't my intention as this is a really good PR. Just want...

Most of the questions I posted above look like they still stand, even after the changes. Some look like they might just be copy/paste type things, but others might be...

As part of any change, I think we probably need to improve some of the wording on these options to indicate exactly what they refer to. 'External Baro sensor' has...

In `readBaro()` you've got the new code for checking the MAP reading (https://github.com/noisymime/speeduino/pull/670/files#diff-cf6893cab52605f0de8b25fc56b15565daa8ea927d1ca9ed99a47ea299d71fcbR493) and updating it, but nothing to prevent this reading happening when the car is running. Surely you...