Joachim Nohl

Results 57 comments of Joachim Nohl

I've maximized the touch area of the icons by wrapping them in a Flexible widget: https://github.com/nohli/google_nav_bar/commit/fa47ff658f85565c063e1801b3198a3bdc41caa4 You could try it by adding this to your pubspec.yaml: ``` google_nav_bar: git: url:...

@sooxt98 try wrapping the GButton/gButton with `Container(color: Colors.red, child: ...)` (in your code line 67, in my fork line 98): before: ![before](https://user-images.githubusercontent.com/43643339/90631420-01ca7680-e223-11ea-91ea-76f401eddaae.png) after: ![after](https://user-images.githubusercontent.com/43643339/90631424-042cd080-e223-11ea-9a77-609d5f07e0cf.png) The red painting also reflects the...

@Purus could you merge and publish this, so the two build warnings disappear? 🙏🏽 ``` /Users/achim/flutter/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:11: warning: [deprecation] Registrar in PluginRegistry has been deprecated import io.flutter.plugin.common.PluginRegistry.Registrar; ^ /Users/achim/flutter/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:41: warning: [deprecation]...

FYI there is a new plugin for getting the Android ID 🙂 https://pub.dev/packages/android_id

> @jmgeffroy I believe it does, read carefully this section [Google Play](https://support.google.com/googleplay/android-developer/answer/6048248) On that page, when collapsing `Persistent identifiers, including Android ID`, it says `Use for non-advertising purposes You can...

@jmgeffroy great! If you're interested, you could open a PR in the android_id README for explaining the necessary steps when using the id.

@srnden because unfortunately the version was not updated as a breaking change (new major version). You could use ``` dependency_overrides: device_info_plus_platform_interface: 2.5.0 ``` Or maybe better, don't use overrides, use...

Since we already had a breaking change for removing the getter, and this PR is fixing bugs where the `androidId` is null, it probably is not a breaking change?

@miquelbeltran I updated the changelog to link the new android_id package (could be handy for users checking why it got removed). It already has a popularity of 70% and so...

@dmhacker you've closed two other issues related to this i think, it affects quite a few users...is there hope for a fix? do you need any logs which would help...