Jirawat Iamsamang

Results 13 comments of Jirawat Iamsamang

@ukrbublik React 15.x didn't have `createRef` and `React.Fragment` used in https://github.com/ukrbublik/react-awesome-query-builder/blob/067ce7fd04974639667d60e5659a2c6b26a28b5d/modules/components/containers/Draggable.jsx#L19 and https://github.com/ukrbublik/react-awesome-query-builder/blob/067ce7fd04974639667d60e5659a2c6b26a28b5d/modules/components/item/Group.jsx#L104 So, if you want to support 15.x, I suggest patching 3.0.0 by replacing those `createRef` and `React.Fragment`...

@jingyuexing @DefenceLogic I found a patch for Window. Please have a look at #357.

@GauriBodke Good work. But the author became [ghost](https://github.com/ghost). so please wait for some reviews. ## My review The author proposed a new way to improve the readability of [regex.json](https://github.com/bee-san/pyWhat/blob/2bdf523cef5db5eda40acaaef5d6dda49b777007/pywhat/Data/regex.json) This...

It seems to be promising, but it's just a prototype and needs a lot of works. For example: - What are the best parameters for RegExScore? (repeat_score, in_score, ascii_score, digit_score,...

It's a raw string literal in C++11. https://stackoverflow.com/a/5460235 > In C++11 you have raw string literals. Sort of like here-text in shells and script languages like Python and Perl and...

Sorry for my misunderstanding. That is the purpose of `R"igl_Qu8mg5v7(`, not the meaning. I think we should ask the author who introduced `basic_function.mako` @skoch9 https://github.com/libigl/libigl-python-bindings/blame/7e8f2edd7db4e139783c3452402fe173e4f58fdc/scripts/basic_function.mako#L7

I suggest using `CMAKE_BUILD_PARALLEL_LEVEL` or `build_ext.parallel` ```python # Set CMAKE_BUILD_PARALLEL_LEVEL to control the parallel build level # across all generators. if "CMAKE_BUILD_PARALLEL_LEVEL" not in os.environ: # self.parallel is a Python...

I guess the main problem was not being able to clone the `libigl` from Github. ``` Checking Build System Performing download step (git clone) for 'libigl-populate' Cloning into 'libigl-src'... fatal:...

Usually, I used [isValid](https://date-fns.org/docs/isValid) and others when dealing date and time. IMHO, some invalid objects cannot considered as empty, but the empty objects may be considered as invalid.

For temporary, use my patch in `package.json` ``` "dependencies": { "is-empty": "nodtem66/is-empty" } ``` waiting @ianstormtaylor release the next version ![image](https://cloud.githubusercontent.com/assets/220425/25218072/baa237c0-25d3-11e7-997e-4fe6212e6b47.png)