noamkfir

Results 9 comments of noamkfir

I'm trying to get the build to pass. I noticed that the chromedriver being used for the e2e tests is 2.35, which is apparently installed by the image in /usr/bin/chromedriver....

# Finally got the build to pass! This mainly involved replacing the prebuilt CircleCI image with a custom image generated using [a fork of CircleCI's dockerfile-wizard](https://github.com/noamkfir/dockerfile-wizard). The custom image is...

@ChadTaljaardt, following up on @gkatsanos's review, I noticed that the `vendor` chunk does not preserve its `chunkhash`, so the PR probably shouldn't be merged just yet. I've fixed it and...

This update: * simplifies the config by resorting to some default and recommended webpack 4 settings * unifies the file and chunk naming strategies for js and css files for...

@jjyyxx I was able to reproduce the leak very easily, so I dug into it a bit and I'm pretty sure this isn't related to my changes. Basically, I discovered...

Thanks @miaulightouch! I've merged your PR into mine.

There are a number of ways to declare functions in JavaScript, but some are better than others. And the worst way looks a lot like a standard function declaration in...

@chapgaga I did not create the pattern and I did not name it. But I do agree with it, for the reasons I mentioned above. Design patterns are descriptions of...

According to [the package.json spec](https://docs.npmjs.com/cli/v8/configuring-npm/package-json): > If you don't plan to publish your package, the name and version fields are optional. That means that we can't rely on there being...