Noah Davis

Results 13 comments of Noah Davis

Alternatively, don't run the docker pull during install, but print post-install instructions to do so.

Seems reasonable, I would accept a patch for it. Note though that it's not just the logging that would need to change - log parsing would also need to be...

Yeah, this is a really good idea. Definitely interested in any patches for this. I'm focused currently on migrating oink to middleware to make it more framework agnostic, which will...

Think this commit addresses the issue you raised, though I'm not convinced that oink is completely thread-safe otherwise. I haven't tried running oink in a multi-threaded environment. One other piece...

I'm guessing there's some characters in the log file that oink doesn't handle gracefully. Can you bisect the log file it's parsing to see if you can determine where it's...

It used to be pretty coupled with Rails when it used controller filters. But now it uses Middleware and activerecord hooks, so you should be able to use it just...

No plans, but seems like a sensible idea. In the very least, oink should not blow up if you've only configured the middleware to log memory footprints (and not AR...

Thank you for this pull request. Any chance you could add a spec to cover this? I will merge with some test coverage. Thanks again.

Since Oink is executed in Rack Middleware, an approach like this might be a good way to go: http://icelab.com.au/articles/wrapping-rack-middleware-to-exclude-certain-urls-for-rails-streaming-responses/ Happy to accept a patch that works similarly to this for...

Seems like this is basically a development-only kind of issue. Are you making use of Oink in development? If not would just suggest turning oink off entirely in development mode....